DomGarguilo commented on PR #5516: URL: https://github.com/apache/accumulo/pull/5516#issuecomment-2859967098
This looks fine to me as long as all the tests are passing. Looking at the changes here though, there are a lot of places where we could avoid converting from a `Path` to a `File` altogether and just use the `Path`. It seems fine to handle that cleanup as a follow on though. This also makes me think it might be a good idea to see where we are using `File` as a param for something where we could/should be using `Path` instead. That seems a lot less trivial of a task though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
