keith-turner commented on code in PR #5575:
URL: https://github.com/apache/accumulo/pull/5575#discussion_r2103000346
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -425,6 +428,7 @@ protected Manager(ServerOpts opts, String[] args) throws
IOException {
log.info("Instance {}", getInstanceID());
timeKeeper = new ManagerTime(this, aconf);
tserverSet = new LiveTServerSet(context, this);
+ context.getPropStore().registerAsListener(SystemPropKey.of(context), this);
Review Comment:
The impl of `registerAsListener` will add the listener to a set, so the
order in which listeners are called will vary at runtime. I am not sure, but
it seems like maybe there is another listener that invalidates the prop store
cache. If this is the case this the listener registered here could execute
before or after the listener that clears the cache depending on their order in
the hash set. That could cause this listener to sometime see config change
and sometimes not. However this analysis may not be correct, drawing this
conclusion based on looking at some of the code. If it is the case maybe a
LinkedHashSet could be used to make the order in which listeners are called
correspond with the order they were added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
