ctubbsii commented on code in PR #5574:
URL: https://github.com/apache/accumulo/pull/5574#discussion_r2112507584
##########
core/src/main/java/org/apache/accumulo/core/util/Halt.java:
##########
@@ -29,27 +31,43 @@ public class Halt {
private static final Logger log = LoggerFactory.getLogger(Halt.class);
public static void halt(final String msg) {
- // ACCUMULO-3651 Changed level to error and added FATAL to message for
slf4j compatibility
- halt(0, new Runnable() {
- @Override
- public void run() {
- log.error("FATAL {}", msg);
- }
- });
+ halt(0, msg, Optional.empty(), null);
Review Comment:
I think some of the other methods are called and explicitly pass 0, which I
still think is weird, but at least it's more explicit, so we can comment there,
if there's a reason to use 0, on a case-by-case basis. I wouldn't expect those
to all be reviewed in this PR, though. Maybe a follow-on at some point, that
also addresses all the negative values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
