keith-turner commented on code in PR #5590:
URL: https://github.com/apache/accumulo/pull/5590#discussion_r2114336911
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/merge/DeleteRows.java:
##########
@@ -287,23 +288,24 @@ private List<Range>
createRangesForDeletion(TabletMetadata tabletMetadata,
if (deleteRange.overlaps(tabletExtent)) {
if (deleteRange.prevEndRow() != null
- && tabletExtent.contains(followingRow(deleteRange.prevEndRow()))) {
- log.trace("Fencing tablet {} files to ({},{}]", tabletExtent,
tabletExtent.prevEndRow(),
- deleteRange.prevEndRow());
+ && tabletExtent.contains(followingRow(deleteRange.prevEndRow()))
+ && !Objects.equals(tabletExtent.prevEndRow(),
deleteRange.prevEndRow())) {
Review Comment:
I would like to have checked that tabletExtent.prevEndRow() is less than
deleteRange.prevEndRow() here, howerver that is cumbersome to do with the
possibility of nulls. Thinking the equals checks w/ the other checks in the if
achieves this, but the intent is not as clear in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
