kevinrr888 commented on code in PR #5547:
URL: https://github.com/apache/accumulo/pull/5547#discussion_r2116170285
##########
core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java:
##########
@@ -150,16 +155,10 @@ public void testConfigurationCreation() {
@Test
public void createKeystoreProvider() throws Exception {
- File targetDir =
-
java.nio.file.Path.of(System.getProperty("user.dir")).resolve("target").toFile();
- File keystoreFile = targetDir.toPath().resolve("create.jks").toFile();
- if (keystoreFile.exists()) {
- if (!keystoreFile.delete()) {
- log.error("Unable to delete {}", keystoreFile);
- }
- }
+ java.nio.file.Path keystoreFile = tempDir.resolve("create.jks");
Review Comment:
```suggestion
Path keystorePath = tempDir.resolve("create.jks");
```
Name change not needed, both are correct
##########
core/src/test/java/org/apache/accumulo/core/conf/HadoopCredentialProviderTest.java:
##########
@@ -46,6 +48,9 @@
@SuppressFBWarnings(value = "PATH_TRAVERSAL_IN", justification = "paths not
set by user input")
public class HadoopCredentialProviderTest {
+ @TempDir
+ private static java.nio.file.Path tempDir;
Review Comment:
```suggestion
private static Path tempDir;
```
Should import Path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
