keith-turner commented on code in PR #5627:
URL: https://github.com/apache/accumulo/pull/5627#discussion_r2138229193
##########
server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletStateChangeIterator.java:
##########
@@ -90,17 +96,17 @@ public void init(SortedKeyValueIterator<Key,Value> source,
Map<String,String> op
}
}
- private Set<KeyExtent> parseMigrations(String migrations) {
+ static Set<KeyExtent> decodeMigrations(String migrations) {
if (migrations == null) {
return Collections.emptySet();
}
try {
Set<KeyExtent> result = new HashSet<>();
- DataInputBuffer buffer = new DataInputBuffer();
byte[] data = Base64.getDecoder().decode(migrations);
- buffer.reset(data, data.length);
- while (buffer.available() > 0) {
- result.add(KeyExtent.readFrom(buffer));
+ DataInputStream input =
+ new DataInputStream(new GZIPInputStream(new
ByteArrayInputStream(data)));
Review Comment:
> Ok, looks like ZStandard may need native code loaded. Snappy doesn't use
native code though, so that could be an option.
Seems like the only way to reasonably use zstd would be to make it
configurable? Then could default to gzip and optionally configure zstd which
would be way better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
