ddanielr commented on code in PR #5630:
URL: https://github.com/apache/accumulo/pull/5630#discussion_r2143236015
##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -269,11 +269,16 @@ static class FateOpsCommand extends SubCommandOpts {
@Parameters(commandDescription = "show service status")
public static class ServiceStatusCmdOpts extends SubCommandOpts {
- @Parameter(names = "--json", description = "provide output in json format
(--noHosts ignored)")
- boolean json = false;
+ @Parameter(names = "--json",
+ description = "provide output in json format (--noHosts ignored).
Options: 'nested' or 'flat'")
+ String json = null;
@Parameter(names = "--noHosts",
Review Comment:
Since the summary info is now the default behavior, the `--noHosts` flag
should be refactored to show all host information instead. The name of the flag
should also be changed to match the new behavior.
##########
server/base/src/main/java/org/apache/accumulo/server/util/Admin.java:
##########
@@ -269,11 +269,16 @@ static class FateOpsCommand extends SubCommandOpts {
@Parameters(commandDescription = "show service status")
public static class ServiceStatusCmdOpts extends SubCommandOpts {
- @Parameter(names = "--json", description = "provide output in json format
(--noHosts ignored)")
- boolean json = false;
+ @Parameter(names = "--json",
+ description = "provide output in json format (--noHosts ignored).
Options: 'nested' or 'flat'")
+ String json = null;
Review Comment:
I don't see the value in the additional summaries `nested` view as that
easily be extracted with jq. `./accumulo admin serviceStatus --json nested |
jq .summaries`
However, both the `nested` and `flat` json options print all the host
information which still produces a large amount of output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
