ibilley7 commented on code in PR #5616:
URL: https://github.com/apache/accumulo/pull/5616#discussion_r2175203473
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -365,6 +365,9 @@ public enum Property {
"A comma separated list of tags to emit with all metrics from the
process. Example:"
+ "\"tag1=value1,tag2=value2\".",
"4.0.0"),
+ GENERAL_MICROMETER_ID_FILTERS("general.micrometer.id.filters", "",
PropertyType.STRING,
+ "A comma separated list of patterns to deny meters with matching id
names. Example: \"foo.*,bar\".",
+ "4.0.0"),
Review Comment:
I reevaluated this and found that when creating a meter id, it allows a
comma to be a part of it. So in order to express a comma as a part of one of
the patterns, I thought about instead of having a comma delimited set of regex
patterns, we would have a comma delimited set of terms for prefixes that would
deny any meters with those prefixes at the start of it's ID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
