keith-turner commented on code in PR #5592:
URL: https://github.com/apache/accumulo/pull/5592#discussion_r2175327308


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -211,6 +212,7 @@ public class Manager extends AbstractServer implements 
LiveTServerSet.Listener {
   private final TabletStateStore rootTabletStore;
   private final TabletStateStore metadataTabletStore;
   private final TabletStateStore userTabletStore;
+  private final ExecutorService workerPool;

Review Comment:
   A more specific name for this pool would make it easier to know the purpose 
of this pool.  Could name it `renamePool` of something like that instead of 
`workerPool`.



##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1557,4 +1562,13 @@ private Map<FateInstanceType,Fate<Manager>> 
getFateRefs() {
   public ServiceLock getLock() {
     return managerLock;
   }
+
+  /**
+   * Get Threads Pool instance which is used by blocked I/O
+   *
+   * @return {@link ExecutorService}
+   */
+  public ExecutorService getWorkerPool() {

Review Comment:
   If the variable name is changed would be good to rename this method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to