dlmarion commented on issue #5693:
URL: https://github.com/apache/accumulo/issues/5693#issuecomment-3028269646
My understanding of the situation is:
1. Most properties can be modified at runtime
2. Whether or not the code responds to the update actually determines
whether it's "fixed" or not
3. The fixed set in Property.java is the current understanding of which
properties respond to change
4. The fixed set, which could be wrong, is used to log a warning when the
property is changed
I'm not sure that adding a field to the constructor is going to fully fix
the issue. It alleviates us from having to maintain a separate data structure,
but it could still be out of date if the code that uses the property changes at
a later point.
A different approach to this could be:
1. Disallow changes to truly fixed properties (instance, rpc, etc.). This
set may be the same set of properties that should not be set in ZooKeeper.
2. Allow any other property to be modified
3. Log warnings when a property has been changed, but not re-read after
some period of time.
However, I'm not sure if that's entirely possible given how the properties
are stored in ZooKeeper. Would require some investigation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
