kevinrr888 commented on code in PR #5662:
URL: https://github.com/apache/accumulo/pull/5662#discussion_r2180959792
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -1123,14 +1121,14 @@ public void run() {
managerClientHandler = new ManagerClientServiceHandler(this);
compactionCoordinator = new CompactionCoordinator(this, fateRefs);
- ServerAddress sa;
var processor = ThriftProcessorTypes.getManagerTProcessor(this,
fateServiceHandler,
compactionCoordinator.getThriftService(), managerClientHandler,
getContext());
-
try {
- sa = TServerUtils.createThriftServer(context, getBindAddress(),
Property.MANAGER_CLIENTPORT,
- processor, "Manager", null, Property.MANAGER_MINTHREADS,
- Property.MANAGER_MINTHREADS_TIMEOUT, Property.MANAGER_THREADCHECK);
+ startThriftServer(() -> {
+ return TServerUtils.createThriftServer(context, getBindAddress(),
+ Property.MANAGER_CLIENTPORT, processor, "Manager", null,
Property.MANAGER_MINTHREADS,
+ Property.MANAGER_MINTHREADS_TIMEOUT, Property.MANAGER_THREADCHECK);
+ }, false);
Review Comment:
My concern was that `updateAdvertiseAddress` will still be called here (even
with `false`), and before this was explicitly avoided. So this is not a problem
since this doesn't start the server yet? I think so, but want to be sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
