keith-turner commented on code in PR #5715:
URL: https://github.com/apache/accumulo/pull/5715#discussion_r2193263840
##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1123,7 +1123,7 @@ private Map<String,String>
modifyPropertiesUnwrapped(String tableName,
} catch (AccumuloException ae) {
Throwable cause = ae.getCause();
if (cause instanceof TableNotFoundException) {
- throw new TableNotFoundException(null, tableName, null, ae);
+ throw (TableNotFoundException) cause;
}
Review Comment:
Each exception has stack trace associated with it. Omitting exceptions and
throwing a cause omits these stack traces from anyone who may be looking at
them to debug a problem. This can make tracking down causes of problems
harder, like you may not even know that a thread took a certain path in the
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
