ctubbsii commented on issue #5695:
URL: https://github.com/apache/accumulo/issues/5695#issuecomment-3050386498
I'm not sure about `RPC_PREFIX` or `MONITOR_PREFIX`, but those are probably
okay to exclude. I haven't fully thought through the risks of allowing them
there, but don't think anybody is asking for them to be configurable in ZK, so
it's fine that they aren't. If there's a feature request, we can consider
adding them.
`INSTANCE_PREFIX` is required to be excluded. It contains bootstrapping
properties, and it makes no sense to store them in ZK... they wouldn't be
usable there.
`COMPACTOR_PREFIX` must be excluded for now. These would override
per-resource group configuration files, and we don't have the ability to store
resource group-specific configs in ZK yet. If we added that, then these could
be allowed. This also applies to other server types that can be placed in
resource groups, but since those predate resource groups, we're stuck with the
historical behavior.
"Fixed" properties are, by definition, those ZK-configurable properties that
are affixed to a specific value on first read, and require a restart for
changes to take effect. So, by definition, they are a subset of the
ZK-configurable properties.
`COMPACTOR_PORTSEARCH` probably got caught up in ensuring all
`*_PORTSEARCH` properties got added to the fixed properties, without
consideration of the fact that `COMPACTOR_PREFIX` isn't allowed (for the
reasons already stated). Since the fixed properties only matter if it's a
zoo-configurable property, then it's probably not causing any harm, but would
probably be good to make this consistent and remove it from the list for
consistency.
I don't think there's anything to do for this one, unless there's demand for
a feature request or to trivially fix the `COMPACTOR_PORTSEARCH` issue. I think
it is not outdated or incorrect, in general. But, it would be easier to
maintain them if the ideas on #5693 were complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
