kevinrr888 commented on code in PR #5732:
URL: https://github.com/apache/accumulo/pull/5732#discussion_r2195888785
##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -471,6 +471,7 @@ public ThreadPoolExecutor getTabletRefreshThreadPool() {
public static void main(String[] args) throws Exception {
try (Manager manager = new Manager(new ConfigOpts(), ServerContext::new,
args)) {
+ manager.init();
Review Comment:
A similar problem was present when the new `BalanceManager` was initially
added. The solution made for that was to still construct the BalanceManager in
the Manager constructor, then call `balanceManager.setManager(this)` in the run
method of Manager. This allows us to keep these as final fields which is nice.
To remain consistent, either
1) BalanceManager needs to be moved to be created in this new init method
or
2) Can construct timeKeeper and tserverSet similarly to how BalanceManager is
I prefer 2 as this allows us to keep these fields final and avoids adding a
new method.
See feccebf0b103dd85d4fd288437b4eb59cda58af7 for how this was resolved for
BalanceManager
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
