ctubbsii commented on PR #5719: URL: https://github.com/apache/accumulo/pull/5719#issuecomment-3059997509
I rebased the changes on the current 2.1, and added commits from Dave and myself that I think fix all the issues I saw. I did notice that by default, I had trouble setting the otel.service.name when running the shell, so jaeger just used a default value. I'm not sure what the issue was, but it has something to do with the accumulo-env.sh that I was using. I didn't look into it very closely, but it should be easy to modify accumulo-env.sh to set the otel.service.name to something useful for the client. I'm not a big fan of the global static boolean, but using GlobalOpenTelemetry is already a global static singleton, so it's not really all that restraining, and it only affects the behavior of our utility code. Other code in the same JVM won't be affected, because they shouldn't be accessing the opentelemetry stuff using our internal utilities. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
