dlmarion commented on code in PR #5726:
URL: https://github.com/apache/accumulo/pull/5726#discussion_r2208239250
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -712,6 +717,44 @@ public void run() {
err.set(null);
JOB_HOLDER.reset();
+ // consecutive failure processing
+ final long totalFailures =
+ errorHistory.values().stream().mapToLong(p ->
p.getSecond().get()).sum();
+ if (totalFailures > 0) {
+ LOG.warn("This Compactor has had {} consecutive failures.
Failures: {}", totalFailures,
+ errorHistory);
Review Comment:
Yeah, I guess that I'm assuming the Throwable in
`Map<TableId,Pair<Throwable,AtomicLong>>` would not really change in
consecutive failures. I guess we could change it to `List<Pair<>>`, or remove
the `Throwable` entirely and just make sure we log it. The exception class does
get logged in the Coordinator when the compaction fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
