keith-turner commented on code in PR #5763:
URL: https://github.com/apache/accumulo/pull/5763#discussion_r2243993888
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ServerAmpleImpl.java:
##########
@@ -65,14 +68,29 @@ public class ServerAmpleImpl extends AmpleImpl implements
Ample {
private final ServerContext context;
private final ScanServerRefStore scanServerRefStore;
+ private final Supplier<ConditionalWriter> sharedMetadataWriter;
+ private final Supplier<ConditionalWriter> sharedUserWriter;
Review Comment:
Seemes like these always come from the context, so maybe we could not store
them and always get them from the context when needed. That may simplify the
constructors in this class a bit.
##########
test/src/main/java/org/apache/accumulo/test/ample/metadata/TestAmple.java:
##########
@@ -213,6 +214,7 @@ protected Retry createUnknownRetry() {
}
@Override
+ @SuppressWarnings("deprecation")
Review Comment:
Why was this added?
##########
server/base/src/main/java/org/apache/accumulo/server/metadata/ServerAmpleImpl.java:
##########
@@ -92,14 +110,16 @@ public TabletsMutator mutateTablets() {
@Override
public ConditionalTabletsMutator conditionallyMutateTablets() {
- return new ConditionalTabletsMutatorImpl(context, getTableMapper());
+ return new ConditionalTabletsMutatorImpl(context, getTableMapper(),
sharedMetadataWriter,
+ sharedUserWriter);
Review Comment:
If not storing a ref to the writers, then seems like could do the following.
```suggestion
return new ConditionalTabletsMutatorImpl(context, getTableMapper(),
context.getSharedMetadataWriter(), context.getSharedUserWriter());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
