keith-turner commented on code in PR #5774:
URL: https://github.com/apache/accumulo/pull/5774#discussion_r2248864357
##########
test/src/main/java/org/apache/accumulo/test/ample/metadata/TestAmple.java:
##########
@@ -258,6 +258,32 @@ public ServiceLock getServiceLock() {
public void setServiceLock(ServiceLock lock) {
context.setServiceLock(lock);
}
+
+ @Override
+ public java.util.function.Supplier<ConditionalWriter>
getSharedMetadataWriter() {
+ return () -> {
Review Comment:
Can these suppliers be memoized? That would make the behavior of test ample
more similar to the real ample. Seems like this is always creating new
conditional writers. If it can be memoized it would make the behavior of test
ample more similar to the real ample.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
