kevinrr888 opened a new pull request, #5798:
URL: https://github.com/apache/accumulo/pull/5798
- Removes FATE metrics which are no longer useful (due to 4.0 FATE changes)
and replaces them with more appropriate metrics.
- These new metrics are: a Gauge to track the number of total threads
per FateExecutor and a Gauge to track the total number of idle threads (not
currently working on a fate operation) per FateExecutor.
- Background info/existing functionality:
- Fate's set of fate executors may change as Fate
config is changed. Each FateExecutor has a pool of threads which work on some
subset of fate operations based on the fate configuration properties. If these
properties are changed such that a FateExecutor is no longer applicable, the
FateExecutor is stopped and new FateExecutor(s) are started to accurately
represent config changes.
- What this means for these metric changes:
- If a FateExecutor is stopped, it's metrics will be
removed from the registry. This avoids the registry getting flooded with
metrics that are no longer applicable/no longer give relevant info on the Fate
system.
- Adds testing for these new metrics in MetricsIT and adds two new classes
to aid in testing these metrics: SlowFateSplitManager and SlowFateSplit.
- Some minor misc. changes:
- Improved description for the deprecated MANAGER_FATE_THREADPOOL_SIZE
property
- Improved the set of non thrift ops in the Fate class to gather the
ops at run time
- Improved the FATE_TX metric description
closes #5147
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
