dlmarion commented on PR #5796: URL: https://github.com/apache/accumulo/pull/5796#issuecomment-3201080594
> Bad: In the case of a clean exit, for a graceful shutdown, I think the background thread could still halt the process and produce an exception and non-zero exit code, but as I've mentioned, it's okay if this PR doesn't try to address that specific case. The lock watcher may halt the process, but would do so with a `0` exit code. All of the server processes `run` methods end in this same general pattern: https://github.com/apache/accumulo/blob/2570c5069433d1d72cb029541c8c34ba8f7e14fe/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java#L712-L720 The last thing that happens is unlocking the lock, which may end up causing the ServiceLockWatcher to fire before the JVM ends. However, it uses a `0` exit code in this case because the shutdownComplete object is set to true. https://github.com/apache/accumulo/blob/2570c5069433d1d72cb029541c8c34ba8f7e14fe/core/src/main/java/org/apache/accumulo/core/lock/ServiceLockSupport.java#L165-L170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
