dlmarion commented on code in PR #5811:
URL: https://github.com/apache/accumulo/pull/5811#discussion_r2304683719
##########
server/base/src/main/java/org/apache/accumulo/server/AbstractServer.java:
##########
@@ -84,15 +84,6 @@ public static void startServer(AbstractServer server, Logger
LOG) throws Excepti
e.printStackTrace();
LOG.error("{} died, exception thrown from runServer.",
server.getClass().getSimpleName(), e);
throw e;
- } finally {
Review Comment:
I don't think we need to. I checked the logs and the Exception and Error are
logged correctly. The issue in #5796 was an exception in the try-with-resources
was being suppressed when an exception happened in the close.
try-with-resources is no longer being used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
