keith-turner commented on code in PR #5833:
URL: https://github.com/apache/accumulo/pull/5833#discussion_r2307805927
##########
core/src/main/java/org/apache/accumulo/core/file/rfile/RFile.java:
##########
@@ -1355,47 +1351,14 @@ public void close() throws IOException {
}
@Override
- public Text getFirstRow() throws IOException {
- if (currentReaders.length == 0) {
- return null;
Review Comment:
This old code would return null when the file was empty. Now it returns
something that explicitly means empty. Other code seemed confused about what
null meant and would expand it to an infinite range, which was harmless and
resulted in files with no data going to all children tablets when a tablet
split. The new code returns some more specific than null to denote empty file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
