ctubbsii commented on code in PR #5775:
URL: https://github.com/apache/accumulo/pull/5775#discussion_r2311721718


##########
core/src/main/java/org/apache/accumulo/core/clientImpl/TableOperationsImpl.java:
##########
@@ -1787,7 +1795,8 @@ public boolean testClassLoad(final String tableName, 
final String className,
     try {
       return ThriftClientTypes.CLIENT.execute(context,
           client -> client.checkTableClass(TraceUtil.traceInfo(), 
context.rpcCreds(), tableName,
-              className, asTypeName));
+              className, asTypeName),
+          rgid -> true);

Review Comment:
   Looks good... but ResourceGroupPredicate.DEFAULT looks like "some default 
predicate implementation" rather than "the resource group named DEFAULT".
   I suggest "ResourceGroupPredicate.DEFAULT_RG_ONLY" or something like that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to