ctubbsii opened a new issue, #5867: URL: https://github.com/apache/accumulo/issues/5867
To ensure we can seal jars during our build, we organize files in separate jars into mutually exclusive packages/resource directories. To ensure this mutual exclusivity, we have a convention of having package/directory names based on the Maven module that builds that jar. (for example, the `core` module that builds `accumulo-core.jar` uses a base package of `org.apache.accumulo.core`). However, we break this convention in several places. Some of these are okay, like how the `minicluster` module has packages `org.apache.accumulo.minicluster` and also `org.apache.accumulo.miniclusterImpl`. This is okay because the package name is still clearly associated with that same Maven module, and there are some reasons we might want to have the implementation classes off to the side, rather than underneath, the base package (for example, to document the public API definition more simply). In other cases, we don't need to break the convention, and we should generally follow the convention whenever possible. In PR #5866, a CI check was added to prevent new convention breakages, and to document the current exceptions. This task is to work through the current exceptions, and relocate them, so that we do not need as many exceptions documented in that CI check. See https://github.com/apache/accumulo/blob/8d04afaac80f7574d0b3d0073093da265a4b9b75/src/build/ci/check-module-package-conventions.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
