kevinrr888 commented on code in PR #5853:
URL: https://github.com/apache/accumulo/pull/5853#discussion_r2323394034
##########
core/src/test/java/org/apache/accumulo/core/file/rfile/bcfile/CompressionTest.java:
##########
@@ -279,41 +279,35 @@ public void testThereCanBeOnlyOne() throws
InterruptedException, ExecutionExcept
ExecutorService service = Executors.newFixedThreadPool(20);
final int numTasks = 40;
- ArrayList<Callable<Boolean>> list = new ArrayList<>(numTasks);
+ ArrayList<Callable<Integer>> list = new ArrayList<>(numTasks);
CountDownLatch startSignal = new CountDownLatch(numTasks);
// keep track of the system's identity hashcodes.
- final HashSet<Integer> testSet = new HashSet<>();
+ final ArrayList<Integer> hashCodes = new ArrayList<>();
Review Comment:
It seems the ArrayList is just converted to HashSet later, why not just use
HashSet from the start?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
