keith-turner commented on code in PR #5875:
URL: https://github.com/apache/accumulo/pull/5875#discussion_r2349781996
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -859,11 +859,11 @@ private void hostSuspendedTablet(TabletLists tLists,
TabletMetadata tm, Location
< tableConf.getTimeInMillis(Property.TABLE_SUSPEND_DURATION)) {
// Tablet is suspended. See if its tablet server is back.
TServerInstance returnInstance = null;
- Iterator<TServerInstance> find = tLists.destinations
- .tailMap(new TServerInstance(tm.getSuspend().server, "
")).keySet().iterator();
+ Iterator<TServerInstance> find =
+
tLists.destinations.tailMap(tm.getSuspend().server).keySet().iterator();
Review Comment:
Looked into handling of negative and zero for that code, it sorts using
unsigned hex so zero would be minimum even if there are negative numbers. In
#5885 updated the impl to use zero and the test use a negative session and it
all works. The test should catch any changes in sorting of zero relative to
negative values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
