ctubbsii commented on code in PR #5865:
URL: https://github.com/apache/accumulo/pull/5865#discussion_r2356526511
##########
server/base/src/main/java/org/apache/accumulo/server/conf/cluster/ClusterConfigParser.java:
##########
@@ -159,8 +159,12 @@ private static void validateConfiguredGroups(final
ServerContext ctx, final Set<
if (!zkGroups.contains(cg)) {
if (createMissingRG) {
try {
- ctx.resourceGroupOperations().create(ResourceGroupId.of(cg));
- } catch (AccumuloException | AccumuloSecurityException e) {
+ // cant use API as servers may not be up when this is called
+ // from accumulo-cluster
+ final ResourceGroupId rgid = ResourceGroupId.of(cg);
+ final ResourceGroupPropKey key = ResourceGroupPropKey.of(rgid);
+ key.createZNode(ctx.getZooSession().asReaderWriter());
+ } catch (KeeperException | InterruptedException e) {
Review Comment:
What I'm suggesting would include the removal of the
ClusterConfigParser.validateConfiguredGroups... since it shouldn't be reading
ZK at all, just the config file. I'm not sure what it needs to validate
anyway... it should be perfectly valid to specify a RG that doesn't have any
custom config in ZK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
