keith-turner commented on code in PR #5890:
URL: https://github.com/apache/accumulo/pull/5890#discussion_r2360753885
##########
.github/workflows/maven.yaml:
##########
@@ -68,15 +68,15 @@ jobs:
- {name: 'unit-tests', javaver: 17, args: 'verify -PskipQA
-DskipTests=false'}
- {name: 'qa-checks', javaver: 17, args: 'verify javadoc:jar
-Psec-bugs -DskipTests -Dspotbugs.timeout=3600000'}
- {name: 'compat', javaver: 17, args: 'package -DskipTests
-Dversion.hadoop=3.0.3 -Dversion.zookeeper=3.5.10'}
- - {name: 'errorprone', javaver: 17, args: 'verify
-Perrorprone,skipQA'}
+ - {name: 'errorprone', javaver: 17, args: 'verify -Derrorprone
-PskipQA'}
Review Comment:
I kinda understand this, see the changes in the pom around this.
##########
pom.xml:
##########
@@ -112,21 +112,39 @@
<url>https://github.com/apache/accumulo/actions</url>
</ciManagement>
<properties>
-
<accumulo.javadoc.since.versions>2.0.0,2.0.1,2.1.0,2.1.1,2.1.2,2.1.3,2.1.4,2.1.5</accumulo.javadoc.since.versions>
+ <!-- properties used by the accumulo build in our own POM files -->
+ <accumulo.build.extraTestArgs>--add-opens java.base/java.lang=ALL-UNNAMED
--add-opens java.base/java.util=ALL-UNNAMED --add-opens
java.base/java.io=ALL-UNNAMED --add-opens java.base/java.net=ALL-UNNAMED
--add-opens java.management/java.lang.management=ALL-UNNAMED --add-opens
java.management/sun.management=ALL-UNNAMED --add-opens
java.base/java.security=ALL-UNNAMED --add-opens
java.base/java.lang.reflect=ALL-UNNAMED --add-opens
java.base/java.util.concurrent=ALL-UNNAMED --add-opens
java.base/java.util.stream=ALL-UNNAMED --add-opens
java.base/java.util.concurrent.atomic=ALL-UNNAMED --add-opens
java.base/java.time=ALL-UNNAMED</accumulo.build.extraTestArgs>
Review Comment:
Were there any changes to this content?
##########
pom.xml:
##########
@@ -933,6 +946,7 @@
<exclude>.vscode/**</exclude>
<exclude>.factorypath</exclude>
<exclude>.github/**</exclude>
+ <exclude>**/*.rf</exclude>
Review Comment:
Why was this added? Did these not cause problems before and w/ a newer rat
plugin version they do now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
