ctubbsii commented on code in PR #5886:
URL: https://github.com/apache/accumulo/pull/5886#discussion_r2361432000


##########
core/src/test/java/org/apache/accumulo/core/spi/compaction/RatioBasedCompactionPlannerTest.java:
##########
@@ -791,7 +791,7 @@ public void testMaxTabletFilesNoCompaction() {
     var overrides2 = new HashMap<>(overrides);
     overrides2.put(Property.COMPACTION_SERVICE_PREFIX.getKey() + 
"cs1.planner.opts.lowestRatio",
         "1.04");
-    var conf2 = new 
ConfigurationImpl(SiteConfiguration.empty().withOverrides(overrides2).build());
+    var conf2 = new ConfigurationImpl(new ConfigurationCopy(overrides2));

Review Comment:
   @keith-turner I created #5896 to implement the improvements I was talking 
about in my last comment. It should make it so you don't have to modify that 
test in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to