ctubbsii commented on code in PR #5913:
URL: https://github.com/apache/accumulo/pull/5913#discussion_r2370220815
##########
test/src/main/java/org/apache/accumulo/test/ScanServerIT.java:
##########
@@ -103,7 +103,6 @@ public void configureMiniCluster(MiniAccumuloConfigImpl cfg,
cfg.setProperty(Property.MANAGER_TABLET_GROUP_WATCHER_INTERVAL, "5");
cfg.setProperty(Property.TSERV_ONDEMAND_UNLOADER_INTERVAL, "10");
-
cfg.setProperty("table.custom.ondemand.unloader.inactivity.threshold.seconds",
"15");
Review Comment:
In the two tests that same to be testing tablet availability, there is a
utility method called `setupTableWithTabletAvailabilityMix`. The property can
be added to the table at the time it is created in that method using
NewTableConfiguration.
If the test is passing without it, though... it makes me wonder whether the
test is actually doing what it is supposed to be doing. However, it's probably
not a correctness thing, but an optimization thing, specifically for line 387
that is waiting 30 seconds for the inactivity-triggered unloads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
