ddanielr commented on code in PR #28:
URL:
https://github.com/apache/accumulo-classloaders/pull/28#discussion_r2373477601
##########
modules/vfs-class-loader/src/test/java/org/apache/accumulo/classloader/vfs/context/ReloadingVFSContextClassLoaderFactoryTest.java:
##########
Review Comment:
This looks like a minor fix separate from the feature being added.
Suggest pulling this out into a separate PR we can immediately merge.
##########
pom.xml:
##########
@@ -128,7 +128,7 @@ under the License.]]></licenseText>
<!-- most dependencies will be provided by the accumulo installation
-->
<groupId>org.apache.accumulo</groupId>
<artifactId>accumulo-project</artifactId>
- <version>2.1.3</version>
+ <version>2.1.4</version>
Review Comment:
pull this out into a separate PR with the formatting changes in case this
breaks anything else.
##########
modules/vfs-class-loader/src/main/java/org/apache/accumulo/classloader/vfs/context/ReloadingVFSContextClassLoaderFactory.java:
##########
Review Comment:
Pull these formatting changes out into a separate PR.
##########
modules/vfs-class-loader/src/test/java/test/HelloWorldTemplate:
##########
@@ -24,4 +24,8 @@ public class HelloWorld {
public String toString() {
return "%%";
}
+
+ public void helloWorld() {
Review Comment:
suggest renaming this method to avoid the same name as the class minus case
differences.
```suggestion
public void validate() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
