keith-turner commented on code in PR #5944:
URL: https://github.com/apache/accumulo/pull/5944#discussion_r2392813643
##########
server/manager/src/main/java/org/apache/accumulo/manager/tableOps/AbstractRepo.java:
##########
@@ -20,19 +20,18 @@
import org.apache.accumulo.core.fate.FateId;
import org.apache.accumulo.core.fate.Repo;
-import org.apache.accumulo.manager.Manager;
-public abstract class ManagerRepo implements Repo<Manager> {
+public abstract class AbstractRepo implements Repo<FateEnv> {
Review Comment:
> I think this could be further simplified, because by making Repo use a
more generic type, FateEnv, it isn't really necessary to have Repo accept a
generic parameter... it can just always be FateEnv.
Not currently, fate test do use other type parameters in order to make
testing simpler. That would be a big change best for another PR, if its even
feasible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
