keith-turner commented on code in PR #5940:
URL: https://github.com/apache/accumulo/pull/5940#discussion_r2388864388
##########
pom.xml:
##########
@@ -850,6 +851,7 @@ under the License.
<excludedGroups>${failsafe.excludedGroups}</excludedGroups>
<groups>${failsafe.groups}</groups>
<systemPropertyVariables combine.children="append">
+
<accumulo.it.uniq.test.dir>${failsafe.unique.accumulo.test.dirs}</accumulo.it.uniq.test.dir>
Review Comment:
If we had a maven property w/ the same name that defaults to false then
maybe this could be
`<accumulo.it.uniq.test.dir>${accumulo.it.uniq.test.dir}</accumulo.it.uniq.test.dir>`
##########
pom.xml:
##########
@@ -141,6 +141,7 @@ under the License.
<failsafe.forkCount>1</failsafe.forkCount>
<failsafe.groups />
<failsafe.reuseForks>false</failsafe.reuseForks>
+
<failsafe.unique.accumulo.test.dirs>false</failsafe.unique.accumulo.test.dirs>
Review Comment:
Could we have a property here instead of a profile like
`<accumulo.it.uniq.test.dir>false</accumulo.it.uniq.test.dir>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
