ctubbsii commented on code in PR #5910:
URL: https://github.com/apache/accumulo/pull/5910#discussion_r2370156947
##########
server/manager/src/main/java/org/apache/accumulo/manager/upgrade/Upgrader11to12.java:
##########
@@ -929,7 +930,8 @@ void moveTableProperties(ServerContext context) {
sysTableProps.forEach((k, v) -> LOG.info("{} -> {}", k, v));
for (String ns : context.namespaceOperations().list()) {
- final NamespacePropKey nsk = NamespacePropKey.of(NamespaceId.of(ns));
+ final NamespaceId nsid = context.getNamespaceId(ns);
Review Comment:
This is using the public API to look up the namespace/Id mapping. It
shouldn't. There is an internal mapping object that it can look up instead
(that part should be upgraded first), so you can avoid the second lookup of the
namespace Id from the name. You can instead iterate over the entrySet directly,
and have access to both the namespace name and id at the same time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
