ctubbsii commented on code in PR #5919:
URL: https://github.com/apache/accumulo/pull/5919#discussion_r2373678013
##########
test/src/main/java/org/apache/accumulo/test/VolumeChooserIT.java:
##########
@@ -296,35 +242,37 @@ public void twoTablesPreferredVolumeChooser() throws
Exception {
@Test
public void twoTablesRandomVolumeChooser() throws Exception {
log.info("Starting twoTablesRandomVolumeChooser()");
+ var namespace1 = "ns_" + getUniqueNames(2)[0];
+ var namespace2 = "ns_" + getUniqueNames(2)[1];
// Create namespace
try (AccumuloClient client =
Accumulo.newClient().from(getClientProperties()).build()) {
- createAndVerify(client, namespace1, v1 + "," + v2 + "," + v3);
- createAndVerify(client, namespace2, v1 + "," + v2 + "," + v3);
+ client.namespaceOperations().create(namespace1);
+ client.namespaceOperations().setProperty(namespace1,
PERTABLE_CHOOSER_PROP,
+ RandomVolumeChooser.class.getName());
+ verifyVolumesForWritesToNewTable(client, namespace1, join(v1, v2, v3));
+ client.namespaceOperations().create(namespace2);
+ client.namespaceOperations().setProperty(namespace2,
PERTABLE_CHOOSER_PROP,
+ RandomVolumeChooser.class.getName());
+ verifyVolumesForWritesToNewTable(client, namespace2, join(v1, v2, v3));
}
}
- private void createAndVerify(AccumuloClient client, String ns, String
expectedVolumes)
- throws Exception {
- client.namespaceOperations().create(ns);
-
- // Set properties on the namespace
- client.namespaceOperations().setProperty(ns, PERTABLE_CHOOSER_PROP,
- RandomVolumeChooser.class.getName());
-
- verifyVolumesForWritesToNewTable(client, ns, expectedVolumes);
- }
-
// Test that uses 2 tables with 10 split points each. The first uses the
RandomVolumeChooser and
// the second uses the StaticVolumeChooser to choose volumes.
Review Comment:
Will fix after rebasing (after #5923 is merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
