keith-turner commented on code in PR #5913:
URL: https://github.com/apache/accumulo/pull/5913#discussion_r2373095209
##########
test/src/main/java/org/apache/accumulo/test/ScanServerIT.java:
##########
@@ -103,7 +103,6 @@ public void configureMiniCluster(MiniAccumuloConfigImpl cfg,
cfg.setProperty(Property.MANAGER_TABLET_GROUP_WATCHER_INTERVAL, "5");
cfg.setProperty(Property.TSERV_ONDEMAND_UNLOADER_INTERVAL, "10");
-
cfg.setProperty("table.custom.ondemand.unloader.inactivity.threshold.seconds",
"15");
Review Comment:
Looked into this and none of the test would benefit from setting this
property. All of the test run faster than the `15s` that property was setting.
Most test run in a few seconds except for one test that has a 30 second sleep
and that is the what accounts for most of the time in that test.
Running the test I saw the following happen.
1. The tests creates 10 tablets with an initial tablet availability of
hosted.
2. Then the test sets some of the tablets to ONDEMAND and the manager
unloads these really quickly after that change.
The reason the manager unloads the tablets so quickly is because of [this
code](https://github.com/apache/accumulo/blob/2c58d2924947d10ed3d018026885d5c24cc4fb87/server/base/src/main/java/org/apache/accumulo/server/manager/state/TabletGoalState.java#L105).
The tablets were hosted w/o ever setting the hosting requested column, so
when the manager sees an ondemand tablet w/o that column it computes a goal of
unassigned. This is expected behavior.
So we do not need to set the property and setting it would be misleading.
Can also make the same change to fix ScanServer_NoServersIT and it also does
not need to the property set for the same reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
