keith-turner commented on code in PR #5980:
URL: https://github.com/apache/accumulo/pull/5980#discussion_r2538836212
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1065,10 +1065,12 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
var deadLogs = tLists.logsForDeadServers;
if (!deadTablets.isEmpty()) {
- int maxServersToShow = min(deadTablets.size(), 100);
- Manager.log.debug("{} assigned to dead servers: {}...",
deadTablets.size(),
- deadTablets.subList(0, maxServersToShow));
- Manager.log.debug("logs for dead servers: {}", deadLogs);
+ Manager.log.debug("{} tablets assigned to dead servers",
deadTablets.size());
+ if (Manager.log.isTraceEnabled()) {
+ Manager.log.trace("logs for dead servers: {}", deadLogs);
Review Comment:
Really long log lines can be hard to deal with sometimes when looking at
logs. Could log a line per log? That adds more data though.
```java
deadLogs.foreach(l->log.trace(....));
```
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1065,10 +1065,12 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
var deadLogs = tLists.logsForDeadServers;
if (!deadTablets.isEmpty()) {
- int maxServersToShow = min(deadTablets.size(), 100);
- Manager.log.debug("{} assigned to dead servers: {}...",
deadTablets.size(),
- deadTablets.subList(0, maxServersToShow));
- Manager.log.debug("logs for dead servers: {}", deadLogs);
+ Manager.log.debug("{} tablets assigned to dead servers",
deadTablets.size());
+ if (Manager.log.isTraceEnabled()) {
+ Manager.log.trace("logs for dead servers: {}", deadLogs);
+ } else {
+ Manager.log.debug("{} logs exist for dead servers", deadLogs.size());
Review Comment:
This is an existing problem, but would it be possible to add the `[Normal
tablets]`, [Metadata tablets]`, etc prefix for these message like other log
message in TGW? Have not looked at this code in a larger context, so not sure
if this make sense. Those prefixes are useful for grepping the output of one
TGW instance.
##########
server/manager/src/main/java/org/apache/accumulo/manager/TabletGroupWatcher.java:
##########
@@ -1065,10 +1065,12 @@ private void handleDeadTablets(TabletLists tLists,
WalStateManager wals)
var deadLogs = tLists.logsForDeadServers;
if (!deadTablets.isEmpty()) {
- int maxServersToShow = min(deadTablets.size(), 100);
- Manager.log.debug("{} assigned to dead servers: {}...",
deadTablets.size(),
- deadTablets.subList(0, maxServersToShow));
- Manager.log.debug("logs for dead servers: {}", deadLogs);
+ Manager.log.debug("{} tablets assigned to dead servers",
deadTablets.size());
+ if (Manager.log.isTraceEnabled()) {
+ Manager.log.trace("logs for dead servers: {}", deadLogs);
+ } else {
+ Manager.log.debug("{} logs exist for dead servers", deadLogs.size());
Review Comment:
This is an existing problem, but would it be possible to add the `[Normal
tablets]`,` [Metadata tablets]`, etc prefix for these message like other log
message in TGW? Have not looked at this code in a larger context, so not sure
if this make sense. Those prefixes are useful for grepping the output of one
TGW instance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
