dlmarion commented on code in PR #5988:
URL: https://github.com/apache/accumulo/pull/5988#discussion_r2557882698
##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -1280,7 +1280,9 @@ public enum Property {
"The durability used to write to the write-ahead log. Legal values are:"
+ " none, which skips the write-ahead log; log, which sends the data
to the"
+ " write-ahead log, but does nothing to make it durable; flush,
which pushes"
- + " data to the file system; and sync, which ensures the data is
written to disk.",
+ + " data to the file system; and sync, which ensures the data is
written to disk."
Review Comment:
> > * Setting `dfs.datanode.synconclose` to true will cause each replicated
block to be synced to disk when it's closed.
>
> Does that supersede the need for us to do anything? Should we just
recommend that to users? We could update the `table.durability` description to
reference it.
Based on my latest comment, I think updating the documentation is
sufficient. If we are going to do something with RFiles for table durability,
then I think we would need to force a replicated file with
`dfs.datanode.synconclose`. We would also need to fail the configuration if
table durability is set to sync and erasure coding is configured. If we don't
fail the configuration somehow, then we will end up consuming more disk space
than what the user intends.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
