keith-turner commented on code in PR #33: URL: https://github.com/apache/accumulo-classloaders/pull/33#discussion_r2590493618
########## modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextCleaner.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.classloader.lcc; + +import java.io.IOException; +import java.lang.ref.Cleaner; +import java.lang.ref.SoftReference; +import java.net.URLClassLoader; +import java.util.ArrayList; +import java.util.List; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LocalCachingContextCleaner { + + private static final Logger LOG = LoggerFactory.getLogger(LocalCachingContextCleaner.class); + private static final List<SoftReference<URLClassLoader>> LOADERS = new ArrayList<>(); + private static final Cleaner CLEANER = Cleaner.create(); + + public static void registerClassLoader(final URLClassLoader cl) { + LOADERS.add(new SoftReference<>(cl)); + CLEANER.register(cl, () -> { Review Comment: Not sure if cleaner is needed, but also not too familiar w/ cleaners. Could do the following to just remove any garbage whenever something is added. Seems like that would work well w/ weak refs. ```suggestion LOADERS.removeIf(ref->ref.get() == null); ``` ########## modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/LocalCachingContextCleaner.java: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.classloader.lcc; + +import java.io.IOException; +import java.lang.ref.Cleaner; +import java.lang.ref.SoftReference; +import java.net.URLClassLoader; +import java.util.ArrayList; +import java.util.List; + +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +public class LocalCachingContextCleaner { + + private static final Logger LOG = LoggerFactory.getLogger(LocalCachingContextCleaner.class); + private static final List<SoftReference<URLClassLoader>> LOADERS = new ArrayList<>(); + private static final Cleaner CLEANER = Cleaner.create(); + + public static void registerClassLoader(final URLClassLoader cl) { + LOADERS.add(new SoftReference<>(cl)); + CLEANER.register(cl, () -> { + LOADERS.removeIf((sr) -> sr.get() == cl); + try { + cl.close(); + } catch (IOException ioe) { + LOG.warn("Error closing LocalCachingContext URLClassLoader", ioe); + } + }); + } + + public static List<URLClassLoader> getReferencedClassLoaders() { + List<URLClassLoader> cll = new ArrayList<>(); + LOADERS.forEach(sr -> cll.add(sr.get())); Review Comment: This should not add things where ref.get() returns null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
