dlmarion commented on code in PR #5998:
URL: https://github.com/apache/accumulo/pull/5998#discussion_r2593565769


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java:
##########
@@ -177,8 +177,10 @@ private SortedKeyValueIterator<Key,Value> createIterator()
       files = reservation.getSecond();
     }
 
-    Collection<InterruptibleIterator> mapfiles =
+    List<InterruptibleIterator> mapfiles =
         fileManager.openFiles(files, scanParams.isIsolated(), samplerConfig);
+    // Randomize the ordering of files to avoid block cache contention on seeks
+    Collections.shuffle(mapfiles);

Review Comment:
   I think you can use `tablet.getTableConfiguration()` to see if a shuffle 
property is set on the table. Another option, which is not currently wired up, 
would be to use an execution hint on a per-scan basis so that not all scans on 
the table are affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to