dlmarion commented on PR #5961: URL: https://github.com/apache/accumulo/pull/5961#issuecomment-3618111798
@kevinrr888 - I was reviewing your https://github.com/apache/accumulo/pull/5948#issuecomment-3608569194 and while I agree with your comment that the JSON is valid, I think the issue is that we are comparing JSON as Strings in the test code and the gson code for serialization order is non-deterministic unless you tell it what the order should be. I think the better solution is to not compare Strings in the test, but deserialize the json back to an object and do object comparison. I'm thinking we should add NonDex to the build to identify these occurrences so we can fix them to do object comparison. Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
