dlmarion commented on code in PR #6009:
URL: https://github.com/apache/accumulo/pull/6009#discussion_r2610404977
##########
server/compactor/src/main/java/org/apache/accumulo/compactor/Compactor.java:
##########
@@ -487,14 +487,14 @@ protected void
updateCompactionState(TExternalCompactionJob job, TCompactionStat
* @param exception cause of failure
* @throws RetriesExceededException thrown when retries have been exceeded
*/
- protected void updateCompactionFailed(TExternalCompactionJob job, Throwable
exception)
+ protected void updateCompactionFailed(TExternalCompactionJob job, String
exception)
Review Comment:
I looked at that and the coordinator actually checks for null at
https://github.com/apache/accumulo/blob/2.1/server/compaction-coordinator/src/main/java/org/apache/accumulo/coordinator/CompactionCoordinator.java#L674.
Basically, if the exception class is not null, then there was a failure and
increment some metrics. If the exception class is null, then just clean it up.
We could make this better, but I figure the more code we change in a patch
release the higher probability we have of introducing another bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
