keith-turner commented on PR #6010: URL: https://github.com/apache/accumulo/pull/6010#issuecomment-3657486331
> Suggest adding scan to the names where it makes sense. For example, accumulo.entries.read, could be relevant for compactions as well. Maybe it doesn't matter in the tracing because it's per thread of execution? It would certainly matter for any metrics emitted as those will be aggregated. Made that change in ae2abb7. These attributes are only used in a span related to scan, so they are scoped to scans in that way. Its probably good to have good attribute names across all span types though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
