kevinrr888 commented on PR #6025: URL: https://github.com/apache/accumulo/pull/6025#issuecomment-3665873740
> How does this static analysis pick which classes to inspect? Does every class that has non volatile and mutable fields have to be marked as not thread safe? I believe it looks at every class, but not entirely sure how it chooses what to flag. I think it looks for common non-thread safe patterns and flags those (e.g., getting and then setting an atomic var in two operations, modifying a non-volatile/non-atomic var in a run(), but also having a getter in that same class, etc.). The documentation is pretty vague. https://spotbugs.readthedocs.io/en/latest/detectors.html It does not seem that every class needs to be marked/considered, I only had to change ~40 for 2.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
