keith-turner commented on code in PR #92:
URL: https://github.com/apache/accumulo-access/pull/92#discussion_r2632520302
##########
core/src/test/java/org/apache/accumulo/access/tests/AccessExpressionTest.java:
##########
@@ -170,10 +168,14 @@ public void testSpecificationDocumentation() throws
IOException, URISyntaxExcept
specLinesFromAbnfFile =
bufferedReader.lines().dropWhile(beforeFirstLine).collect(toList());
}
- // grab from the markdown, but make sure to skip the markdown triple ticks
- List<String> specLinesFromMarkdownFile =
Files.readAllLines(Path.of("SPECIFICATION.md"))
- .stream().dropWhile(line -> !line.startsWith("```ABNF")).skip(1)
- .takeWhile(line -> !line.startsWith("```")).collect(toList());
+ List<String> specLinesFromMarkdownFile;
+ try (var specFile =
AccessExpression.class.getResourceAsStream("/SPECIFICATION.md");
Review Comment:
What caused this change?
##########
README.md:
##########
@@ -58,35 +58,33 @@ Add the library to your CLASSPATH. For Maven, use:
## Running the [Examples](src/test/java/example)
-To run [AccessExample](src/test/java/example/AccessExample.java)
+To run
[AccessExample](examples/src/main/java/org/apache/accumulo/access/examples/AccessExample.java)
```
mvn clean package
-java --module-path=$(ls target/accumulo-access-*.jar)
--add-modules=accumulo.access src/test/java/example/AccessExample.java
-java --module-path=$(ls target/accumulo-access-*.jar)
--add-modules=accumulo.access src/test/java/example/AccessExample.java RED BLUE
+java
--module-path=core/target/accumulo-access-core-1.0.0-SNAPSHOT.jar:examples/target/accumulo-access-examples-1.0.0-SNAPSHOT.jar
--add-modules=accumulo.access,accumulo.access.examples
--module=accumulo.access.examples/org.apache.accumulo.access.examples.AccessExample
Review Comment:
Now that all the code is in modules, do not need to add the modules.
```suggestion
java
--module-path=core/target/accumulo-access-core-1.0.0-SNAPSHOT.jar:examples/target/accumulo-access-examples-1.0.0-SNAPSHOT.jar
--module=accumulo.access.examples/org.apache.accumulo.access.examples.AccessExample
```
Or can add only the example module and then directly call the class in it
w/o using --modules
```suggestion
java
--module-path=core/target/accumulo-access-core-1.0.0-SNAPSHOT.jar:examples/target/accumulo-access-examples-1.0.0-SNAPSHOT.jar
--add-modules accumulo.access.examples
org.apache.accumulo.access.examples.AccessExample
```
##########
antlr4-example/src/main/java/module-info.java:
##########
@@ -0,0 +1,24 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * https://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+module accumulo.access.examples.antlr {
+ exports org.apache.accumulo.access.antlr4;
+ exports org.apache.accumulo.access.grammars;
+ requires transitive accumulo.access;
+ requires transitive org.antlr.antlr4.runtime;
Review Comment:
So this project already has module support?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
