keith-turner commented on code in PR #6027:
URL: https://github.com/apache/accumulo/pull/6027#discussion_r2636593156


##########
test/src/main/java/org/apache/accumulo/test/TableOperationsIT.java:
##########
@@ -1037,6 +1040,58 @@ public void testGetTabletInformation() throws Exception {
         });
       }
 
+      var unboundedStartRange = RowRange.atMost(new Text("4"));

Review Comment:
   There are 8 cases of inclusive/exclusive inf/not-inf combos and not sure 
they are all being covered.  Seems like a subset of those are covered.  The 
following is where I tried to work out what cases were covered by the current 
test, not sure if its correct though.  Including in case its useful.
   
   ```java
   RowRange.range(null, true, Y, false);
   RowRange.range(null, true, Y, true); // covered
   RowRange.range(X, false, null, true);
   RowRange.range(X, true, null, true); //covered
   RowRange.range(X, false, Y, false);
   RowRange.range(X, false, Y, true); // covered
   RowRange.range(X, true, Y, false);
   RowRange.range(X, true, Y, true); //covered
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to