ddanielr commented on code in PR #6038:
URL: https://github.com/apache/accumulo/pull/6038#discussion_r2651504246


##########
server/monitor/src/main/resources/org/apache/accumulo/monitor/resources/external/datatables/js/jquery.dataTables.js:
##########
@@ -10514,7 +10514,7 @@
                 *      } );
                 *    } );
                 */
-               "aLengthMenu": [ 10, 25, 50, 100 ],
+               "aLengthMenu": [[10, 25, 50, 100, -1], [10, 25, 50, 100, 
"All"]],

Review Comment:
   @DomGarguilo 
   I moved the changes over. I agree that keeping track of this in external 
when upgrading deps would be annoying. 
   
   I had originally tried making the changes in `table.js` but I would see an 
empty selected option on random refreshes. I did not see that same issue when 
using your suggested changes. 
   
   Tested this locally and didn't see problems when using the auto-refresh.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to