keith-turner commented on code in PR #36:
URL:
https://github.com/apache/accumulo-classloaders/pull/36#discussion_r2687720774
##########
modules/local-caching-classloader/src/main/java/org/apache/accumulo/classloader/lcc/util/LocalStore.java:
##########
@@ -290,12 +292,17 @@ private Path storeResource(final Resource resource)
throws IOException {
}
}
+ private static final int DL_BUFF_SIZE = 1024 * 1024;
+
private void downloadFile(FileResolver source, Path tempPath, Resource
resource) {
// CREATE_NEW ensures the temporary file name is unique for this attempt
- // SYNC ensures file integrity on each write, in case of system failure
- try (var in = source.getInputStream();
- var out = Files.newOutputStream(tempPath, CREATE_NEW, WRITE, SYNC)) {
+ // SYNC ensures file integrity on each write, in case of system failure.
Buffering minimizes
+ // system calls te read/write data which minimizes the number of syncs.
+ try (var in = new BufferedInputStream(source.getInputStream(),
DL_BUFF_SIZE);
+ var out = new BufferedOutputStream(Files.newOutputStream(tempPath,
CREATE_NEW, WRITE, SYNC),
+ DL_BUFF_SIZE)) {
in.transferTo(out);
+ out.close();
Review Comment:
I tried the following and build failed because the modenizer plugin wants
`File.newOutputStream()`
```java
try (var in = new BufferedInputStream(source.getInputStream(),
DL_BUFF_SIZE);
var fsout = new FileOutputStream(tempPath.toFile(), false);
var out = new BufferedOutputStream(fsout, DL_BUFF_SIZE)) {
in.transferTo(out);
out.flush();
fsout.getFD().sync();
final String checksum = DIGESTER.digestAsHex(tempPath);
if (!resource.getChecksum().equals(checksum)) {
Files.delete(tempPath);
throw new IllegalStateException(
"Checksum " + checksum + " for resource " +
resource.getLocation()
+ " does not match checksum in context definition " +
resource.getChecksum());
}
} catch (IOException e) {
throw new UncheckedIOException(e);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
