dlmarion commented on PR #40:
URL:
https://github.com/apache/accumulo-classloaders/pull/40#issuecomment-3751893498
> I think it's possible that the either the scheduler, or the cleanUp may
not be needed on the weakValues map, but I'm not sure. I don't think they are
doing any harm, though.
I spoke with @ctubbsii, putting my comment here for awareness. If the
cleanup is not done on the weak values map, then the last call to `exists =
cache.anyMatch("TEST"::equals);` in the test will return `true` instead of
`false`. This is because the key remains in the weak values map, and it is
mapped to null because the value is cleared out because of the `weakValues`.
I'm not sure if both the scheduler and the cleanup is needed, but I agree that
it's likely not doing much harm here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
