kevinrr888 commented on code in PR #6040:
URL: https://github.com/apache/accumulo/pull/6040#discussion_r2695412387


##########
server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/ScanDataSource.java:
##########
@@ -243,6 +245,26 @@ private SortedKeyValueIterator<Key,Value> createIterator()
       } else {
         // Scan time iterator options were set, so need to merge those with 
pre-parsed table
         // iterator options.
+
+        // First ensure the set iterators do not conflict with the existing 
table iterators.
+        for (var scanParamIterInfo : scanParams.getSsiList()) {

Review Comment:
   > Also curious if the validation could efficiently be done in the existing 
IteratorConfigUtil.mergeIteratorConfig()
   
   Unfortunately not since there is no looping done here that we can add to to 
check for conflicts. This method loops through table iterator options and the 
scan parameters iterator options. To check for conflicts we need to iterate 
through the iterator infos.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to